fix/udpate comments.

clean up.

7 files changed, 36 insertions, 31 deletions

diff --git a/fml/lib/FML/CGI/Admin/Menu.pm b/fml/lib/FML/CGI/Admin/Menu.pm
index 66514dec..aa15bff5 100644
--- a/fml/lib/FML/CGI/Admin/Menu.pm
+++ b/fml/lib/FML/CGI/Admin/Menu.pm
@@ -1,10 +1,10 @@
 #-*- perl -*-
 #
-#  Copyright (C) 2002,2003 Ken'ichi Fukamachi
+#  Copyright (C) 2002,2003,2004 Ken'ichi Fukamachi
 #   All rights reserved. This program is free software; you can
 #   redistribute it and/or modify it under the same terms as Perl itself.
 #
-# $FML: Menu.pm,v 1.27 2003/09/25 11:40:58 fukachan Exp $
+# $FML: Menu.pm,v 1.28 2004/01/18 13:56:06 fukachan Exp $
 #
 
 package FML::CGI::Admin::Menu;
@@ -80,7 +80,7 @@ Ken'ichi Fukamachi
 
 =head1 COPYRIGHT
 
-Copyright (C) 2002,2003 Ken'ichi Fukamachi
+Copyright (C) 2002,2003,2004 Ken'ichi Fukamachi
 
 All rights reserved. This program is free software; you can
 redistribute it and/or modify it under the same terms as Perl itself.
diff --git a/fml/lib/FML/CGI/MLAdmin/Menu.pm b/fml/lib/FML/CGI/MLAdmin/Menu.pm
index 5521ad53..785ab896 100644
--- a/fml/lib/FML/CGI/MLAdmin/Menu.pm
+++ b/fml/lib/FML/CGI/MLAdmin/Menu.pm
@@ -1,10 +1,10 @@
 #-*- perl -*-
 #
-#  Copyright (C) 2002,2003 Ken'ichi Fukamachi
+#  Copyright (C) 2002,2003,2004 Ken'ichi Fukamachi
 #   All rights reserved. This program is free software; you can
 #   redistribute it and/or modify it under the same terms as Perl itself.
 #
-# $FML: Menu.pm,v 1.26 2003/08/29 15:33:56 fukachan Exp $
+# $FML: Menu.pm,v 1.1 2003/09/25 11:40:57 fukachan Exp $
 #
 
 package FML::CGI::MLAdmin::Menu;
@@ -80,7 +80,7 @@ Ken'ichi Fukamachi
 
 =head1 COPYRIGHT
 
-Copyright (C) 2002,2003 Ken'ichi Fukamachi
+Copyright (C) 2002,2003,2004 Ken'ichi Fukamachi
 
 All rights reserved. This program is free software; you can
 redistribute it and/or modify it under the same terms as Perl itself.
diff --git a/fml/lib/FML/Command/Auth.pm b/fml/lib/FML/Command/Auth.pm
index 398903de..9b88d9c0 100644
--- a/fml/lib/FML/Command/Auth.pm
+++ b/fml/lib/FML/Command/Auth.pm
@@ -4,7 +4,7 @@
 #   All rights reserved. This program is free software; you can
 #   redistribute it and/or modify it under the same terms as Perl itself.
 #
-# $FML: Auth.pm,v 1.31 2004/01/01 23:52:10 fukachan Exp $
+# $FML: Auth.pm,v 1.32 2004/01/02 14:50:30 fukachan Exp $
 #
 
 package FML::Command::Auth;
@@ -145,6 +145,7 @@ sub check_admin_member_password
     my $address  = $optargs->{ address };
     my $password = $optargs->{ password };
     unless ($address && $password) {
+	# XXX-TODO: please return error message.
 	return 0;
     }
 
diff --git a/fml/lib/FML/Command/DataCheck.pm b/fml/lib/FML/Command/DataCheck.pm
index 037876fb..7cb6b53e 100644
--- a/fml/lib/FML/Command/DataCheck.pm
+++ b/fml/lib/FML/Command/DataCheck.pm
@@ -4,7 +4,7 @@
 #   All rights reserved. This program is free software; you can
 #   redistribute it and/or modify it under the same terms as Perl itself.
 #
-# $FML: DataCheck.pm,v 1.11 2003/09/08 15:06:04 fukachan Exp $
+# $FML: DataCheck.pm,v 1.12 2004/01/02 14:42:43 fukachan Exp $
 #
 
 package FML::Command::DataCheck;
@@ -64,7 +64,7 @@ sub parse_command_buffer
 sub parse_command_arguments
 {
     my ($self, $command, $comname) = @_;
-    my $found = 0;
+    my $found     = 0;
     my (@options) = ();
 
     # XXX-TODO: $comname matches exactly.
@@ -85,7 +85,7 @@ sub parse_command_arguments
 
 
 # Descriptions: check the message of the current process to find
-#               whether it contais some special keyword e.g. "confirm".
+#               whether it contains some special keyword e.g. "confirm".
 #    Arguments: OBJ($self) OBJ($curproc) ARRAY_REF($ra_data)
 # Side Effects: none
 # Return Value: HASH_REF
@@ -134,6 +134,8 @@ sub find_commands_for_stranger
     my $commands = $config->get_as_array_ref('commands_for_stranger');
     my $body     = $curproc->incoming_message_body();
     my $msg      = $body->find_first_plaintext_message();
+
+    # XXX-TODO: use message_text_as_array_ref().
     my (@body)   = split(/\n/, $msg->message_text );
     my $comname  = '';
 
diff --git a/fml/lib/FML/Command/DirUtils.pm b/fml/lib/FML/Command/DirUtils.pm
index 5821efe0..0c63e378 100644
--- a/fml/lib/FML/Command/DirUtils.pm
+++ b/fml/lib/FML/Command/DirUtils.pm
@@ -1,10 +1,10 @@
 #-*- perl -*-
 #
-#  Copyright (C) 2002,2003 Ken'ichi Fukamachi
+#  Copyright (C) 2002,2003,2004 Ken'ichi Fukamachi
 #   All rights reserved. This program is free software; you can
 #   redistribute it and/or modify it under the same terms as Perl itself.
 #
-# $FML: DirUtils.pm,v 1.14 2003/08/23 07:24:42 fukachan Exp $
+# $FML: DirUtils.pm,v 1.15 2003/08/29 15:33:57 fukachan Exp $
 #
 
 package FML::Command::DirUtils;
@@ -29,7 +29,7 @@ FML::Command::DirUtils - utilities for directory handlings
 =cut
 
 
-# Descriptions: standard constructor
+# Descriptions: standard constructor.
 #    Arguments: OBJ($self)
 # Side Effects: none
 # Return Value: OBJ
@@ -49,7 +49,7 @@ sub new
 # XXX-TODO: if we can find CPAN module for dir listing, use it.
 #
 
-# Descriptions: show the result by executing "ls"
+# Descriptions: show the result by executing "ls".
 #    Arguments: OBJ($self)
 #               OBJ($curproc) HASH_REF($command_args) HASH_REF($du_args)
 # Side Effects: none
@@ -72,6 +72,7 @@ sub dir
 	}
 	else {
 	    $curproc->logwarn("deny ls options '$opt'");
+	    $opt_ls = '';
 	}
     }
 
@@ -79,7 +80,7 @@ sub dir
     my $safe = $self->{ _safe };
 
     # chdir the ml's home dir
-    my $ml_home_dir    = $config->{ ml_home_dir };
+    my $ml_home_dir = $config->{ ml_home_dir };
     chdir $ml_home_dir || croak("cannot chdir \$ml_home_dir");
 
     # build safe arguments
@@ -122,7 +123,7 @@ Ken'ichi Fukamachi
 
 =head1 COPYRIGHT
 
-Copyright (C) 2002,2003 Ken'ichi Fukamachi
+Copyright (C) 2002,2003,2004 Ken'ichi Fukamachi
 
 All rights reserved. This program is free software; you can
 redistribute it and/or modify it under the same terms as Perl itself.
diff --git a/fml/lib/FML/Command/FileUtils.pm b/fml/lib/FML/Command/FileUtils.pm
index f788069f..496028eb 100644
--- a/fml/lib/FML/Command/FileUtils.pm
+++ b/fml/lib/FML/Command/FileUtils.pm
@@ -1,10 +1,10 @@
 #-*- perl -*-
 #
-#  Copyright (C) 2002,2003 Ken'ichi Fukamachi
+#  Copyright (C) 2002,2003,2004 Ken'ichi Fukamachi
 #   All rights reserved. This program is free software; you can
 #   redistribute it and/or modify it under the same terms as Perl itself.
 #
-# $FML: FileUtils.pm,v 1.13 2003/08/23 07:24:42 fukachan Exp $
+# $FML: FileUtils.pm,v 1.14 2003/08/29 15:33:57 fukachan Exp $
 #
 
 package FML::Command::FileUtils;
@@ -73,8 +73,8 @@ sub delete
 
 
 # Descriptions: remove files
-#    Arguments: OBJ($self) HASH_REF($curproc) HASH_REF($command_args)
-#               HASH_REF($du_args)
+#    Arguments: OBJ($self) 
+#               OBJ($curproc) HASH_REF($command_args) HASH_REF($du_args)
 # Side Effects: none
 # Return Value: none
 sub remove
@@ -88,7 +88,7 @@ sub remove
     my $safe = $self->{ _safe };
 
     # chdir $ml_home_dir firstly. return ASAP if failed.
-    my $ml_home_dir    = $config->{ ml_home_dir };
+    my $ml_home_dir = $config->{ ml_home_dir };
     chdir $ml_home_dir || croak("cannot chdir \$ml_home_dir");
 
     for my $file (@$argv) {
@@ -141,7 +141,7 @@ Ken'ichi Fukamachi
 
 =head1 COPYRIGHT
 
-Copyright (C) 2002,2003 Ken'ichi Fukamachi
+Copyright (C) 2002,2003,2004 Ken'ichi Fukamachi
 
 All rights reserved. This program is free software; you can
 redistribute it and/or modify it under the same terms as Perl itself.
diff --git a/fml/lib/FML/Install.pm b/fml/lib/FML/Install.pm
index 08eb39d7..511abdee 100644
--- a/fml/lib/FML/Install.pm
+++ b/fml/lib/FML/Install.pm
@@ -1,10 +1,10 @@
 #-*- perl -*-
 #
-#  Copyright (C) 2003 Ken'ichi Fukamachi
+#  Copyright (C) 2003,2004 Ken'ichi Fukamachi
 #   All rights reserved. This program is free software; you can
 #   redistribute it and/or modify it under the same terms as Perl itself.
 #
-# $FML: Install.pm,v 1.9 2003/12/21 14:39:05 fukachan Exp $
+# $FML: Install.pm,v 1.10 2003/12/26 14:51:37 fukachan Exp $
 #
 
 package FML::Install;
@@ -244,7 +244,7 @@ install sample .cf files:
 # Return Value: none
 sub install_sample_cf_files
 {
-    my ($self) = @_;
+    my ($self)     = @_;
     my $config     = $self->{ _config };
     my $config_dir = $self->path( 'config_dir' );
     my $samples    = $config->get_as_array_ref('sample_cf_files');
@@ -301,6 +301,7 @@ sub install_default_config_files
 	# always override.
 	$self->convert($src, $dst, 0644);
 
+	# XXX-TODO: fix tricky installation of default_config.cf.
 	# always override.
 	# XXX we need install default_config.cf too! (caution: mandatory)
 	if ($dst =~ /\.$nl_language$/) {
@@ -331,7 +332,7 @@ sub install_default_config_files
 sub install_mtree_dir
 {
     my ($self) = @_;
-    my $config  = $self->{ _config };
+    my $config = $self->{ _config };
 
     # XXX src = relative path, dst = absolute path
     my $dst_dir = File::Spec->catfile($self->path( 'default_config_dir' ),
@@ -364,7 +365,7 @@ install files under fml/share/.
 # Return Value: none
 sub install_lib_dir
 {
-    my ($self) = @_;
+    my ($self)  = @_;
     my $config  = $self->{ _config };
     my $dst_dir = $self->path( 'lib_dir' );
     my $src_dir = '';
@@ -758,9 +759,9 @@ return the absolute directory path for the specified type C<$dir>.
 sub path
 {
     my ($self, $dir) = @_;
-    my $config     = $self->{ _config };
-    my $version    = $self->get_version();
-    my $config_dir = $config->{ config_dir };
+    my $config       = $self->{ _config };
+    my $version      = $self->get_version();
+    my $config_dir   = $config->{ config_dir };
 
     if ($dir eq 'prefix'      ||
 	$dir eq 'exec_prefix' ||
@@ -1027,7 +1028,7 @@ Ken'ichi Fukamachi
 
 =head1 COPYRIGHT
 
-Copyright (C) 2003 Ken'ichi Fukamachi
+Copyright (C) 2003,2004 Ken'ichi Fukamachi
 
 All rights reserved. This program is free software; you can
 redistribute it and/or modify it under the same terms as Perl itself.