overhaul: fix comments and messages. validate initial value.

5 files changed, 33 insertions, 29 deletions

diff --git a/fml/lib/FML/Command/Admin/digest.pm b/fml/lib/FML/Command/Admin/digest.pm
index 159aece4..676fc708 100644
--- a/fml/lib/FML/Command/Admin/digest.pm
+++ b/fml/lib/FML/Command/Admin/digest.pm
@@ -4,7 +4,7 @@
 #   All rights reserved. This program is free software; you can
 #   redistribute it and/or modify it under the same terms as Perl itself.
 #
-# $FML: digest.pm,v 1.19 2004/04/28 04:10:36 fukachan Exp $
+# $FML: digest.pm,v 1.20 2004/04/30 13:38:05 fukachan Exp $
 #
 
 package FML::Command::Admin::digest;
@@ -50,14 +50,14 @@ sub new
 }
 
 
-# Descriptions: need lock or not
+# Descriptions: need lock or not.
 #    Arguments: none
 # Side Effects: none
 # Return Value: NUM( 1 or 0)
 sub need_lock { 1;}
 
 
-# Descriptions: lock channel
+# Descriptions: lock channel.
 #    Arguments: none
 # Side Effects: none
 # Return Value: STR
@@ -94,7 +94,7 @@ sub process
     # XXX 1) may be not writable.
     # XXX 2) ambigous and dangerous
     # XXX    since the map is under controlled by other module.
-    # XXX    for example, one of member_maps is under admin_member_maps.
+    # XXX    for example, member_maps contains different classes.
     my $recipient_map         = $config->{ primary_recipient_map };
     my $recipient_maps        = $config->get_as_array_ref('recipient_maps');
     my $digest_recipient_map  = $config->{ primary_digest_recipient_map };
@@ -202,6 +202,8 @@ sub _digest_on
     else {
 	$self->_useradd($curproc, $command_args, $uc_digest_args);
     }
+
+    # XXX-TODO: need transaction ?
 }
 
 
@@ -260,6 +262,8 @@ sub _digest_off
     else {
 	$self->_useradd($curproc, $command_args, $uc_normal_args);
     }
+
+    # XXX-TODO: need transaction ?
 }
 
 
diff --git a/fml/lib/FML/Command/Admin/digestoff.pm b/fml/lib/FML/Command/Admin/digestoff.pm
index 981a4530..134bda09 100644
--- a/fml/lib/FML/Command/Admin/digestoff.pm
+++ b/fml/lib/FML/Command/Admin/digestoff.pm
@@ -4,7 +4,7 @@
 #   All rights reserved. This program is free software; you can
 #   redistribute it and/or modify it under the same terms as Perl itself.
 #
-# $FML: digestoff.pm,v 1.10 2004/02/15 04:38:29 fukachan Exp $
+# $FML: digestoff.pm,v 1.11 2004/04/28 04:10:36 fukachan Exp $
 #
 
 package FML::Command::Admin::digestoff;
@@ -15,7 +15,7 @@ use vars qw(@ISA @EXPORT @EXPORT_OK $AUTOLOAD);
 
 =head1 NAME
 
-FML::Command::Admin::digest - digest mode off
+FML::Command::Admin::digest - digest mode off (from digest to real time).
 
 =head1 SYNOPSIS
 
@@ -33,7 +33,7 @@ It means delivery to this address from digest to real delivery mode.
 =cut
 
 
-# Descriptions: standard constructor
+# Descriptions: constructor.
 #    Arguments: OBJ($self)
 # Side Effects: none
 # Return Value: OBJ
@@ -46,14 +46,14 @@ sub new
 }
 
 
-# Descriptions: need lock or not
+# Descriptions: need lock or not.
 #    Arguments: none
 # Side Effects: none
 # Return Value: NUM( 1 or 0)
 sub need_lock { 1;}
 
 
-# Descriptions: lock channel
+# Descriptions: lock channel.
 #    Arguments: none
 # Side Effects: none
 # Return Value: STR
diff --git a/fml/lib/FML/Command/Admin/digeston.pm b/fml/lib/FML/Command/Admin/digeston.pm
index e2185d66..ba503805 100644
--- a/fml/lib/FML/Command/Admin/digeston.pm
+++ b/fml/lib/FML/Command/Admin/digeston.pm
@@ -4,7 +4,7 @@
 #   All rights reserved. This program is free software; you can
 #   redistribute it and/or modify it under the same terms as Perl itself.
 #
-# $FML: digeston.pm,v 1.10 2004/02/15 04:38:29 fukachan Exp $
+# $FML: digeston.pm,v 1.11 2004/04/28 04:10:36 fukachan Exp $
 #
 
 package FML::Command::Admin::digeston;
@@ -15,7 +15,7 @@ use vars qw(@ISA @EXPORT @EXPORT_OK $AUTOLOAD);
 
 =head1 NAME
 
-FML::Command::Admin::digest - digest mode on
+FML::Command::Admin::digest - digest mode on (from real time to digest).
 
 =head1 SYNOPSIS
 
@@ -33,7 +33,7 @@ change delivery mode to this address from real to digest one.
 =cut
 
 
-# Descriptions: standard constructor
+# Descriptions: constructor.
 #    Arguments: OBJ($self)
 # Side Effects: none
 # Return Value: OBJ
@@ -46,14 +46,14 @@ sub new
 }
 
 
-# Descriptions: need lock or not
+# Descriptions: need lock or not.
 #    Arguments: none
 # Side Effects: none
 # Return Value: NUM( 1 or 0)
 sub need_lock { 1;}
 
 
-# Descriptions: lock channel
+# Descriptions: lock channel.
 #    Arguments: none
 # Side Effects: none
 # Return Value: STR
@@ -74,7 +74,7 @@ sub verify_syntax
 }
 
 
-# Descriptions: digest mode off/on for the specified user.
+# Descriptions: digest mode on for the specified user.
 #               change delivery mode to this address from real to digest one.
 #    Arguments: OBJ($self) OBJ($curproc) HASH_REF($command_args)
 # Side Effects: update $recipient_map,$digest_recipient_maps
@@ -94,7 +94,7 @@ sub process
 }
 
 
-# Descriptions: show cgi menu for digeston
+# Descriptions: show cgi menu for digest on.
 #    Arguments: OBJ($self) OBJ($curproc) HASH_REF($command_args)
 # Side Effects: update $recipient_map
 # Return Value: none
diff --git a/fml/lib/FML/Command/Admin/on.pm b/fml/lib/FML/Command/Admin/on.pm
index d9e551ca..9ad65ae9 100644
--- a/fml/lib/FML/Command/Admin/on.pm
+++ b/fml/lib/FML/Command/Admin/on.pm
@@ -4,7 +4,7 @@
 #   All rights reserved. This program is free software; you can
 #   redistribute it and/or modify it under the same terms as Perl itself.
 #
-# $FML: on.pm,v 1.18 2004/04/28 04:10:37 fukachan Exp $
+# $FML: on.pm,v 1.19 2004/04/30 13:38:05 fukachan Exp $
 #
 
 package FML::Command::Admin::on;
@@ -15,7 +15,7 @@ use Carp;
 
 =head1 NAME
 
-FML::Command::Admin::on - change delivery mode from digest to real time
+FML::Command::Admin::on - change delivery mode from digest to real time.
 
 =head1 SYNOPSIS
 
@@ -32,7 +32,7 @@ change delivery mode from digest to real time.
 =cut
 
 
-# Descriptions: constructor
+# Descriptions: constructor.
 #    Arguments: OBJ($self)
 # Side Effects: none
 # Return Value: OBJ
@@ -45,14 +45,14 @@ sub new
 }
 
 
-# Descriptions: need lock or not
+# Descriptions: need lock or not.
 #    Arguments: none
 # Side Effects: none
 # Return Value: NUM( 1 or 0)
 sub need_lock { 1;}
 
 
-# Descriptions: lock channel
+# Descriptions: lock channel.
 #    Arguments: none
 # Side Effects: none
 # Return Value: STR
@@ -82,8 +82,8 @@ sub process
     my ($self, $curproc, $command_args) = @_;
     my $config  = $curproc->config();
     my $cred    = $curproc->{ credential };
-    my $options = $command_args->{ options };
-    my $address = $command_args->{ command_data } || $options->[ 0 ];
+    my $options = $command_args->{ options } || [];
+    my $address = $command_args->{ command_data } || $options->[ 0 ] || '';
 
     # XXX We should always add/rewrite only $primary_*_map maps via
     # XXX command mail, CUI and GUI.
@@ -91,7 +91,7 @@ sub process
     # XXX 1) may be not writable.
     # XXX 2) ambigous and dangerous
     # XXX    since the map is under controlled by other module.
-    # XXX    for example, one of member_maps is under admin_member_maps.
+    # XXX    for example, $member_maps contains different classes.
     my $recipient_map = $config->{ primary_recipient_map };
 
     # fundamental check
@@ -144,7 +144,7 @@ sub process
 }
 
 
-# Descriptions: show cgi menu for on
+# Descriptions: show cgi menu for on.
 #    Arguments: OBJ($self) OBJ($curproc) HASH_REF($command_args)
 # Side Effects: update $recipient_map
 # Return Value: none
diff --git a/fml/lib/FML/Command/Admin/spool.pm b/fml/lib/FML/Command/Admin/spool.pm
index f01afa07..ccaa67c8 100644
--- a/fml/lib/FML/Command/Admin/spool.pm
+++ b/fml/lib/FML/Command/Admin/spool.pm
@@ -4,7 +4,7 @@
 #   All rights reserved. This program is free software; you can
 #   redistribute it and/or modify it under the same terms as Perl itself.
 #
-# $FML: spool.pm,v 1.5 2004/03/23 04:20:46 fukachan Exp $
+# $FML: spool.pm,v 1.6 2004/03/24 00:14:09 fukachan Exp $
 #
 
 package FML::Command::Admin::spool;
@@ -15,7 +15,7 @@ use Carp;
 
 =head1 NAME
 
-FML::Command::Admin::spool - small maintenance jobs on the spool directory
+FML::Command::Admin::spool - small maintenance jobs on the spool directory.
 
 =head1 SYNOPSIS
 
@@ -45,14 +45,14 @@ sub new
 }
 
 
-# Descriptions: need lock or not
+# Descriptions: need lock or not.
 #    Arguments: none
 # Side Effects: none
 # Return Value: NUM( 1 or 0)
 sub need_lock { 1;}
 
 
-# Descriptions: lock channel
+# Descriptions: lock channel.
 #    Arguments: none
 # Side Effects: none
 # Return Value: STR