summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorfukachan <fukachan>2004-06-26 11:33:30 +0000
committerfukachan <fukachan>2004-06-26 11:33:30 +0000
commitc476378a8134b3dd2836b86d41f72c9947e087fa (patch)
tree252b3b3f3142c8ed5d22aa29fd629f65ba25dae9
parent0e1f1cfd6e05103f5e5d41fcef10c46b38da83ba (diff)
downloadfml8-c476378a8134b3dd2836b86d41f72c9947e087fa.tar.gz
fml8-c476378a8134b3dd2836b86d41f72c9947e087fa.tar.bz2
fml8-c476378a8134b3dd2836b86d41f72c9947e087fa.zip
fix comments.
quotemeta search key.
-rw-r--r--fml/lib/FML/Command/Auth.pm20
1 files changed, 11 insertions, 9 deletions
diff --git a/fml/lib/FML/Command/Auth.pm b/fml/lib/FML/Command/Auth.pm
index 74654e81..b5d1e511 100644
--- a/fml/lib/FML/Command/Auth.pm
+++ b/fml/lib/FML/Command/Auth.pm
@@ -4,7 +4,7 @@
# All rights reserved. This program is free software; you can
# redistribute it and/or modify it under the same terms as Perl itself.
#
-# $FML: Auth.pm,v 1.36 2004/04/23 13:45:15 fukachan Exp $
+# $FML: Auth.pm,v 1.37 2004/04/27 13:37:48 fukachan Exp $
#
package FML::Command::Auth;
@@ -19,7 +19,7 @@ my $lock_channel = "auth_map_modify";
=head1 NAME
-FML::Command::Auth - authentication functions
+FML::Command::Auth - authentication functions.
=head1 SYNOPSIS
@@ -61,7 +61,7 @@ sub reject
}
-# Descriptions: permit anyone
+# Descriptions: permit anyone.
# Arguments: OBJ($self) OBJ($curproc) HASH_REF($optargs)
# Side Effects: none
# Return Value: NUM
@@ -73,7 +73,7 @@ sub permit_anyone
}
-# Descriptions: permit if admin_member_maps has the sender
+# Descriptions: permit if admin_member_maps has the sender.
# Arguments: OBJ($self) OBJ($curproc) HASH_REF($optargs)
# Side Effects: none
# Return Value: NUM
@@ -125,7 +125,7 @@ check the password if it is valid or not as an administrator.
# HASH_REF($curproc)
# HASH_REF($optargs)
# Side Effects: none
-# Return Value: NUM
+# Return Value: NUM(1 if success, 0 if fail)
sub check_admin_member_password
{
my ($self, $curproc, $optargs) = @_;
@@ -146,6 +146,7 @@ sub check_admin_member_password
my $password = $optargs->{ password } || '';
unless ($address && $password) {
# XXX-TODO: please return error message.
+ $curproc->logerror("FML::Command::Auth: unsafe address input");
return 0;
}
@@ -196,7 +197,7 @@ sub check_admin_member_password
$curproc->log("$function: password match");
}
$password_match = 1;
- $status = 1;
+ $status = 1;
last PASSWORD_ENTRY;
}
}
@@ -233,11 +234,11 @@ sub check_admin_member_password
=cut
-# Descriptions:
+# Descriptions: change password.
# Arguments: OBJ($self)
# OBJ($curproc) HASH_REF($command_args) HASH_REF($up_args)
# Side Effects: admin password modified.
-# Return Value: NUM
+# Return Value: NUM(1 if success, 0 if fail)
sub change_password
{
my ($self, $curproc, $command_args, $up_args) = @_;
@@ -261,7 +262,8 @@ sub change_password
$obj->touch();
# delete
- my ($addrs) = $obj->find( $address, { all => 1 });
+ my $_address = quotemeta($address);
+ my ($addrs) = $obj->find( $_address, { all => 1 });
if (@$addrs) {
my $found = 0;
for my $a (@$addrs) {