diff options
| author | fukachan <fukachan> | 2003-01-29 04:46:53 +0000 |
|---|---|---|
| committer | fukachan <fukachan> | 2003-01-29 04:46:53 +0000 |
| commit | 670e2f85089210a3e782d147c3ef4de0ca2cace0 (patch) | |
| tree | f1de6219ac64c91c8536d7f4a75b5a3658781e0b | |
| parent | ea5c4b9363d7d7b6f9626fd2d43ef0de105bee90 (diff) | |
| download | fml8-670e2f85089210a3e782d147c3ef4de0ca2cace0.tar.gz fml8-670e2f85089210a3e782d147c3ef4de0ca2cace0.tar.bz2 fml8-670e2f85089210a3e782d147c3ef4de0ca2cace0.zip | |
FNF: not use $_
| -rw-r--r-- | fml/lib/File/CacheDir.pm | 4 | ||||
| -rw-r--r-- | fml/lib/File/Utils.pm | 7 | ||||
| -rw-r--r-- | fml/lib/IO/Adapter/AtomicFile.pm | 5 |
3 files changed, 9 insertions, 7 deletions
diff --git a/fml/lib/File/CacheDir.pm b/fml/lib/File/CacheDir.pm index f676dbc4..32622951 100644 --- a/fml/lib/File/CacheDir.pm +++ b/fml/lib/File/CacheDir.pm @@ -4,7 +4,7 @@ # All rights reserved. This program is free software; you can # redistribute it and/or modify it under the same terms as Perl itself. # -# $FML: CacheDir.pm,v 1.21 2002/09/28 09:27:43 fukachan Exp $ +# $FML: CacheDir.pm,v 1.22 2002/12/23 14:34:22 fukachan Exp $ # package File::CacheDir; @@ -278,7 +278,7 @@ sub get_latest_value opendir($dh, $dir); my @dh = (); - for (readdir($dh)) { push(@dh, $_) if /^\d+/;} + for my $dir (readdir($dh)) { push(@dh, $dir) if $dir =~ /^\d+/;} @dh = sort { $b <=> $a } @dh; eval q{ use File::Spec;}; diff --git a/fml/lib/File/Utils.pm b/fml/lib/File/Utils.pm index e857fe56..d62ed8f9 100644 --- a/fml/lib/File/Utils.pm +++ b/fml/lib/File/Utils.pm @@ -4,7 +4,7 @@ # All rights reserved. This program is free software; you can # redistribute it and/or modify it under the same terms as Perl itself. # -# $FML: Utils.pm,v 1.20 2003/01/11 15:14:23 fukachan Exp $ +# $FML: Utils.pm,v 1.21 2003/01/11 15:16:33 fukachan Exp $ # package File::Utils; @@ -237,8 +237,9 @@ sub append my $wh = new FileHandle ">> $dst"; if (defined($rh) && defined($wh)) { - while (<$rh>) { - print $wh $_; + my $buf = ''; + while ($buf = <$rh>) { + print $wh $buf; } $wh->close(); $rh->close(); diff --git a/fml/lib/IO/Adapter/AtomicFile.pm b/fml/lib/IO/Adapter/AtomicFile.pm index 7ff1998c..1fcecb57 100644 --- a/fml/lib/IO/Adapter/AtomicFile.pm +++ b/fml/lib/IO/Adapter/AtomicFile.pm @@ -4,7 +4,7 @@ # All rights reserved. This program is free software; you can # redistribute it and/or modify it under the same terms as Perl itself. # -# $FML: AtomicFile.pm,v 1.5 2002/12/22 02:54:12 fukachan Exp $ +# $FML: AtomicFile.pm,v 1.6 2002/12/23 15:15:08 fukachan Exp $ # package IO::Adapter::AtomicFile; @@ -228,7 +228,8 @@ sub copy my $wh = $self->open($dst); if (defined($rh) && defined($wh)) { - while (sysread($rh, $_, 4096)) { print $wh $_;} + my $buf = ''; + while (sysread($rh, $buf, 4096)) { print $wh $buf;} $wh->close; $rh->close; |