diff options
3 files changed, 25 insertions, 2 deletions
diff --git a/platform-paper/src/main/kotlin/dev/m1sk9/lunaticChat/paper/listener/PlayerPresenceListener.kt b/platform-paper/src/main/kotlin/dev/m1sk9/lunaticChat/paper/listener/PlayerPresenceListener.kt index fc79ffe..6418f6f 100644 --- a/platform-paper/src/main/kotlin/dev/m1sk9/lunaticChat/paper/listener/PlayerPresenceListener.kt +++ b/platform-paper/src/main/kotlin/dev/m1sk9/lunaticChat/paper/listener/PlayerPresenceListener.kt @@ -95,6 +95,6 @@ class PlayerPresenceListener( channelManager?.setPlayerChannel(playerId, null) // 3. Trigger async save of player settings - playerSettingsManager.saveToDisk() + playerSettingsManager.queueSave() } } diff --git a/platform-paper/src/main/kotlin/dev/m1sk9/lunaticChat/paper/settings/PlayerSettingsManager.kt b/platform-paper/src/main/kotlin/dev/m1sk9/lunaticChat/paper/settings/PlayerSettingsManager.kt index 9ee8d5a..110390d 100644 --- a/platform-paper/src/main/kotlin/dev/m1sk9/lunaticChat/paper/settings/PlayerSettingsManager.kt +++ b/platform-paper/src/main/kotlin/dev/m1sk9/lunaticChat/paper/settings/PlayerSettingsManager.kt @@ -66,8 +66,20 @@ class PlayerSettingsManager( } /** + * Queues a debounced asynchronous save without changing any setting. + * + * Used where the caller wants what is already in memory flushed soon - a player leaving, say - + * rather than paying for a write it does not need. + */ + fun queueSave() { + storage.queueAsyncSave(::snapshot) + } + + /** * Forces an immediate synchronous save of all settings to disk. - * This should only be called during plugin shutdown. + * + * Serializes every stored player and writes the whole file inline, so this belongs on the + * shutdown path only; everywhere else should use [queueSave] or [updateSettings]. */ fun saveToDisk() { storage.saveToDisk(snapshot()) diff --git a/platform-paper/src/test/kotlin/dev/m1sk9/lunaticChat/paper/settings/PlayerSettingsManagerTest.kt b/platform-paper/src/test/kotlin/dev/m1sk9/lunaticChat/paper/settings/PlayerSettingsManagerTest.kt index b7e1385..3c34295 100644 --- a/platform-paper/src/test/kotlin/dev/m1sk9/lunaticChat/paper/settings/PlayerSettingsManagerTest.kt +++ b/platform-paper/src/test/kotlin/dev/m1sk9/lunaticChat/paper/settings/PlayerSettingsManagerTest.kt @@ -154,6 +154,17 @@ class PlayerSettingsManagerTest { } @Test + fun `queueSave should not write on the calling thread`() { + val (manager, storage, _) = createManager() + manager.initialize() + + manager.queueSave() + + verify(exactly = 1) { storage.queueAsyncSave(any()) } + verify(exactly = 0) { storage.saveToDisk(any()) } + } + + @Test fun `multiple players should have independent settings`() { val (manager, _, _) = createManager() manager.initialize() |