overhaul:

o fix comments.
o fix messages/error messages.
o use //o if could.
o specify initial value.

3 files changed, 23 insertions, 22 deletions

diff --git a/fml/lib/FML/Command/User/admin.pm b/fml/lib/FML/Command/User/admin.pm
index 978543df..c662261e 100644
--- a/fml/lib/FML/Command/User/admin.pm
+++ b/fml/lib/FML/Command/User/admin.pm
@@ -4,7 +4,7 @@
 #   All rights reserved. This program is free software; you can
 #   redistribute it and/or modify it under the same terms as Perl itself.
 #
-# $FML: admin.pm,v 1.7 2004/03/14 09:05:05 fukachan Exp $
+# $FML: admin.pm,v 1.8 2004/04/30 13:39:15 fukachan Exp $
 #
 
 package FML::Command::User::admin;
@@ -65,7 +65,7 @@ sub rewrite_prompt
 }
 
 
-# Descriptions: need lock or not
+# Descriptions: need lock or not.
 #    Arguments: none
 # Side Effects: none
 # Return Value: NUM( 1 or 0)
@@ -265,7 +265,7 @@ sub _apply_new_admin_command_mail_restrictions
 	    return 0;
 	}
 	else {
-	    $curproc->log("unknown result");
+	    $curproc->log("unknown result: $result");
 	    return 0;
 	}
     }
diff --git a/fml/lib/FML/Command/User/digest.pm b/fml/lib/FML/Command/User/digest.pm
index 3d4dfe36..64c1bd2a 100644
--- a/fml/lib/FML/Command/User/digest.pm
+++ b/fml/lib/FML/Command/User/digest.pm
@@ -4,7 +4,7 @@
 #   All rights reserved. This program is free software; you can
 #   redistribute it and/or modify it under the same terms as Perl itself.
 #
-# $FML: digest.pm,v 1.12 2004/02/24 14:36:52 fukachan Exp $
+# $FML: digest.pm,v 1.13 2004/04/23 04:10:32 fukachan Exp $
 #
 
 package FML::Command::User::digest;
@@ -15,7 +15,7 @@ use Carp;
 
 =head1 NAME
 
-FML::Command::User::digest - change delivery mode between digest and real time
+FML::Command::User::digest - change delivery mode between digest and real time.
 
 =head1 SYNOPSIS
 
@@ -32,7 +32,7 @@ change delivery mode among real time and digest.
 =cut
 
 
-# Descriptions: standard constructor
+# Descriptions: constructor.
 #    Arguments: OBJ($self)
 # Side Effects: none
 # Return Value: OBJ
@@ -45,14 +45,14 @@ sub new
 }
 
 
-# Descriptions: need lock or not
+# Descriptions: need lock or not.
 #    Arguments: none
 # Side Effects: none
 # Return Value: NUM( 1 or 0)
 sub need_lock { 1;}
 
 
-# Descriptions: lock channel
+# Descriptions: lock channel.
 #    Arguments: none
 # Side Effects: none
 # Return Value: STR
@@ -76,7 +76,7 @@ sub process
     # XXX 1) may be not writable.
     # XXX 2) ambigous and dangerous
     # XXX    since the map is under controlled by other module.
-    # XXX    for example, one of member_maps is under admin_member_maps.
+    # XXX    for example, $member_maps contains different classes.
     my $member_map    = $config->{ primary_member_map };
     my $recipient_map = $config->{ primary_recipient_map };
     my $cache_dir     = $config->{ db_dir };
@@ -99,7 +99,7 @@ sub process
 	return;
     }
 
-    if ($command =~ /digest\s+(\w+)/) {
+    if ($command =~ /digest\s+(\w+)/o) {
     	$mode = $1;
     }
 
@@ -119,13 +119,14 @@ sub process
 	    $obj->process($curproc, $command_args);
 	}
 	else {
-	    $curproc->logerror("unknown digest mode: $mode");
-	    croak("no such digest mode: off or on");
+	    my $r = "digest: unknown mode: $mode";
+	    $curproc->logerror($r);
+	    croak($r);
 	}
     }
     else {
-	$curproc->logerror("digest: mode not specified");
-	croak("digest: mode not specified");
+	$curproc->logerror("digest: mode unspecified");
+	croak("digest: mode unspecified");
     }
 }
 
diff --git a/fml/lib/FML/Command/User/unsubscribe.pm b/fml/lib/FML/Command/User/unsubscribe.pm
index a1a22c58..5b9309d0 100644
--- a/fml/lib/FML/Command/User/unsubscribe.pm
+++ b/fml/lib/FML/Command/User/unsubscribe.pm
@@ -4,7 +4,7 @@
 #   All rights reserved. This program is free software; you can
 #   redistribute it and/or modify it under the same terms as Perl itself.
 #
-# $FML: unsubscribe.pm,v 1.28 2004/03/13 11:46:33 fukachan Exp $
+# $FML: unsubscribe.pm,v 1.29 2004/04/23 04:10:32 fukachan Exp $
 #
 
 package FML::Command::User::unsubscribe;
@@ -15,7 +15,7 @@ use Carp;
 
 =head1 NAME
 
-FML::Command::User::unsubscribe - unsubscribe request handling
+FML::Command::User::unsubscribe - unsubscribe request handling.
 
 =head1 SYNOPSIS
 
@@ -33,7 +33,7 @@ After confirmation succeeds, unsubcribe process proceeds.
 =cut
 
 
-# Descriptions: standard constructor
+# Descriptions: constructor.
 #    Arguments: OBJ($self)
 # Side Effects: none
 # Return Value: OBJ
@@ -46,21 +46,21 @@ sub new
 }
 
 
-# Descriptions: need lock or not
+# Descriptions: need lock or not.
 #    Arguments: none
 # Side Effects: none
 # Return Value: NUM( 1 or 0)
 sub need_lock { 1;}
 
 
-# Descriptions: lock channel
+# Descriptions: lock channel.
 #    Arguments: none
 # Side Effects: none
 # Return Value: STR
 sub lock_channel { return 'command_serialize';}
 
 
-# Descriptions: unsubscribe adapter: confirm before unsubscribe
+# Descriptions: unsubscribe adapter: confirm before unsubscribe.
 #    Arguments: OBJ($self) OBJ($curproc) HASH_REF($command_args)
 # Side Effects: update database for confirmation.
 #               prepare reply message.
@@ -77,7 +77,7 @@ sub process
     # XXX 1) may be not writable.
     # XXX 2) ambigous and dangerous
     # XXX    since the map is under controlled by other module.
-    # XXX    for example, one of member_maps is under admin_member_maps.
+    # XXX    for example, $member_maps contains different classes.
     my $member_map    = $config->{ primary_member_map };
     my $recipient_map = $config->{ primary_recipient_map };
     my $cache_dir     = $config->{ db_dir };
@@ -99,7 +99,7 @@ sub process
 	}
     }
 
-    # exatct match as could as possible.
+    # exact match as could as possible.
     my $compare_level = $cred->get_compare_level();
     $cred->set_compare_level( 100 );